feat(#983): add merge proposal voting UI for source key holders - #1003
Merged
Merged
Conversation
… holders Add merge proposal banner to the source key detail page with live vote tally, deadline countdown, and post-deadline outcome states. - Add MergeProposal domain types (status, vote direction) - Add mergeProposal.service for fetching proposals and casting votes - Add useMergeProposal (30s poll, stops once voting closes) and useCastMergeVote (optimistic update with rollback) hooks - Add MergeProposalCountdown for a ticking deadline countdown - Add MergeProposalBanner: approve/reject actions gated to qualifying holders, live approval % vs threshold tally, outcome badge for passed/failed/pending_execution - Wire banner into CreatorDetailPage - Add unit tests for tally/threshold/outcome utils and banner gating, voting, and outcome states Closes accesslayerorg#983
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…al setQueryData calls setQueryData's typed overload mis-inferred userVote as `undefined` when passed a plain object literal with an explicit generic. Switch both call sites to updater functions to resolve the CI build failure.
Member
|
Merge conflict |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add merge proposal banner to the source key detail page with live
vote tally, deadline countdown, and post-deadline outcome states.
useCastMergeVote (optimistic update with rollback) hooks
holders, live approval % vs threshold tally, outcome badge for
passed/failed/pending_execution
voting, and outcome states
Closes #983